This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[Bugfix] Fix Zend Headers creation when converting from PSR #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also have a slightly performance boost as the headers object is not generated anymore since they're lazy loaded by `zendframework/zend-http` `Headers` object if needed
|
Thanks, @boesing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, any header is being created as an
Zend\Http\Header\GenericHeaderinstance, even if there is a dedicated class provided for a specific header.This only happens if neither
php://tempnorphp://memorywas used while creating the PSR-7 response.This will fix the header creation if the response is a filesystem stream.