This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
New coding standard #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
reviewed
Dec 15, 2016
| - if [[ $TEST_COVERAGE != 'true' ]]; then ./vendor/bin/phpunit ; fi | ||
| - if [[ $EXECUTE_CS_CHECK == 'true' ]]; then ./vendor/bin/phpcs ; fi | ||
| - if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; else composer test ; fi | ||
| - if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi |
There was a problem hiding this comment.
it's called CHECK_CS on line 46
|
@Koopzington ok now it's running but obviously there are some cs failures - also looks like the cs check wasn't working before :( Would you like to solve this as well in your PR? |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the newly introduced zendframework/zend-coding-standard for CS checks.