Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Fixes creating instance via invoke with null options in DiServiceFactory #18

Merged
merged 2 commits into from Oct 18, 2019
Merged

Fixes creating instance via invoke with null options in DiServiceFactory #18

merged 2 commits into from Oct 18, 2019

Conversation

michalbundyra
Copy link
Member

Fixes #9

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@michalbundyra michalbundyra added this to the 1.2.1 milestone Sep 6, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+2.9%) to 45.299% when pulling bf4b000 on webimpress:hotfix/di-service-factory-null-options into 8cf1477 on zendframework:master.

@michalbundyra michalbundyra merged commit 2fdd1f4 into zendframework:master Oct 18, 2019
michalbundyra added a commit that referenced this pull request Oct 18, 2019
@michalbundyra
Merge pull request #18 from webimpress/hotfix/di-service-factory-null…
ff3fd0e 
…-options

Fixes creating instance via invoke with null options in DiServiceFactory
michalbundyra added a commit that referenced this pull request Oct 18, 2019
@michalbundyra
Adds CHANGELOG entry for #18
239deb4
michalbundyra added a commit that referenced this pull request Oct 18, 2019
@michalbundyra
Merge branch 'hotfix/18'
b812594 
Close #18
Fix #9
michalbundyra added a commit that referenced this pull request Oct 18, 2019
@michalbundyra
Merge branch 'hotfix/18' into develop
508f4f6 
Forward port #18
@michalbundyra michalbundyra deleted the hotfix/di-service-factory-null-options branch October 18, 2019 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@froschdesign froschdesign froschdesign approved these changes

@Xerkus Xerkus Awaiting requested review from Xerkus

@weierophinney weierophinney Awaiting requested review from weierophinney

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Argument 2 passed to Zend\ServiceManager\Di\DiServiceFactory::get()
3 participants
@michalbundyra @coveralls @froschdesign