This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Destroy should only return false when removal of session truely fails. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been confirmed that the fast_finish flag is responsible for triggering multiple build notifications on #zftalk.dev.
|
Please merge! |
|
Tests are missing
…On 7 Feb 2017 20:16, "Markus" ***@***.***> wrote:
Please merge!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakA6o78NeAbBQTTDnQhb-1fak0Bv1ks5raMMSgaJpZM4K3Bu7>
.
|
|
@rarog can you provide the tests? |
…ruely fails. Finally fixes #36
|
Sorry, I had those ready since long time, but never commited them, as I didn't manage to set up a local testing environment. |
|
I give up so far, I'm just shooting into the dark, without being sure to hit the target. Can somebody help me resolving the issue with the test? I think I almost got it, but I'm not sure how to work around "expected to be a reference, value given" problem, so the parameter is passed by reference to the mocked function. |
|
@Ocramius It seems, I can't mock for the 2nd test properly due to limitations of the framework (phpspec/prophecy#225) If it is enough, I'd leave the first test in place and remove the 2nd. |
Remove fast_finish flag
New coding standard
Enable Travis CI slack notifications Conflicts: .travis.yml
Fix the configuration key in the documentation
Destroy should only return false when removal of session truely fails.
`Cache::getItem()` expects to return the second argument by reference. Updated the expectation to do this.
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
|
Thanks, @rarog |
|
Thanks! Finally we can use redis session caching. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fixes #36
Until this commit, the Cache adapter still fails. This mimics the behaviour of the fix in DbTableGateway.php.