This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Ensure component works against PHP 7.1+ #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7.1 tests pass, but there are issues with recent zend-servicemanager updates that are causing unrelated failures. I'll try and address those before doing a release; it looks like #78 may address those issues already. |
`AbstractContainer` inherits from `Zend\Stdlib\ArrayObject`. `ArrayObject::offsetGet()` is defined such as to _return by reference_; however, the override in `AbstractContainer` did not. This casuses an issue in current alpha versions of PHP 7.2, as it is considered an incompatible signature. This patch updates the `AbstractContainer::offsetGet()` declaration to return by reference. All tests related to containers continue to pass.
A number of `session.*` INI options were removed starting in 7.1, causing tests to fail. This patch updates the test suite to skip tests for INI options that do not exist when run under 7.1.
weierophinney
force-pushed
the
hotfix/signatures
branch
from
919be9a
to
3f515bc
Compare
|
I'll do a 2.7.4 release with this patch, and then a 2.8.0 with the #78 patches; this will allow more easily back-porting the patch to the 2.4 series to ensure that series works with 7.1. |
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
Forward port #79 Conflicts: CHANGELOG.md
|
Tell me if you'd like me to rebase #78 against develop, or you prefer to manually cherrypick it |
|
@Slamdunk I can do the rebase, no worries. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes two changes:
AbstractContainer::offsetGetto return by reference, matching what it inherits fromZend\Stdlib\ArrayObject. This fixes an issue on PHP 7.2 alpha builds, where the difference in signatures creates a fatal error.SessionConfigtests to skip tests forsession.*INI options that are no longer available in PHP 7.1+.