This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Add PHP 7.1 & 7.2 support, drop PHP 5.5 & HHVM, add PHPUnit 6 support #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been confirmed that the fast_finish flag is responsible for triggering multiple build notifications on #zftalk.dev.
…ruely fails. Finally fixes zendframework#36
Add support for Zend v3 FactoryInterface by considering the $requestedName parameter when creating a SessionManager instance. This allows applications to extend SessionManager by still using the default factory with all its logic.
Slamdunk
changed the title
Slamdunk
changed the title
Slamdunk
changed the title
…fications Enable Travis CI slack notifications Conflicts: .travis.yml
Close zendframework#56 Close zendframework#65 Close zendframework#72
Forward port zendframework#56 Forward port zendframework#65 Forward port zendframework#72
…_fix_config_key Fix the configuration key in the documentation
Forward port zendframework#61
Destroy should only return false when removal of session truely fails.
`Cache::getItem()` expects to return the second argument by reference. Updated the expectation to do this.
Forward port zendframework#66
`AbstractContainer` inherits from `Zend\Stdlib\ArrayObject`. `ArrayObject::offsetGet()` is defined such as to _return by reference_; however, the override in `AbstractContainer` did not. This casuses an issue in current alpha versions of PHP 7.2, as it is considered an incompatible signature. This patch updates the `AbstractContainer::offsetGet()` declaration to return by reference. All tests related to containers continue to pass.
A number of `session.*` INI options were removed starting in 7.1, causing tests to fail. This patch updates the test suite to skip tests for INI options that do not exist when run under 7.1.
Forward port zendframework#79 Conflicts: CHANGELOG.md
SessionManager creates instance of $requestedName
- Assign new variable name vs re-use of `$requestedName`. - Use ternary for initial assignment of `$managerClass`. - Space after `!` operator - Updated test names to reflect behavior being tested.
Add PHP 7.1 & 7.2 support, drop PHP 5.5 & HHVM, add PHPUnit 6 support Conflicts: .travis.yml composer.json src/Config/SessionConfig.php src/Config/StandardConfig.php test/Config/SessionConfigTest.php test/Config/StandardConfigTest.php test/SessionManagerTest.php test/StorageTest.php
Updated build matrix to follow lowest/locked/latest strategy, which will make testing easire going forward.
|
@Slamdunk I've updated this to remove conflicts, and to improve the build matrix. |
New expectation introduced in zendframework#73 to use modern exception expectation method.
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
|
Thanks, @Slamdunk; merged to develop for release with 2.8.0 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fatal error: Declaration of Zend\Session\AbstractContainer::offsetGet($key) must be compatible with & Zend\Stdlib\ArrayObject::offsetGet($key) in ./zend-session/src/AbstractContainer.php on line 27