This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Added support for http-interop/http-middleware 0.5.0 (no BC Break) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep also support for previous version. Now it depends on the library consumer what version of http-middleware to use. We accomplish that by using external library `webimpress/http-middleware-compatibility`.
|
Rebased and changed target to |
This was referenced Oct 7, 2017
Added support for http-interop/http-middleware 0.5.0 (no BC Break)
zendframework/zend-expressive#517
Merged
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2017
Added support for http-interop/http-middleware 0.5.0 (no BC Break)
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2017
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2017
|
Thanks, @webimpress! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep also support for previous version. Now it depends on the library consumer what version of http-middleware to use. We accomplish that by using external library
webimpress/http-middleware-compatibility.Please note that tests runs with lowest/locked/latest dependencies. I've set
composer.lockon http-middleware 0.4.1, lowest will be 0.1.1 and latest 0.5.0. All test pass :)Probably we don't need support version http-middleware 0.1.1 anymore, so can add conflict condition in composer. To support it, I've added in two place method
nextas proxy to methodhandle(also new method, to support http-middleware 0.5.0) - and nowprocessis proxy tohandle.Definitely we need update documentation a bit more. I'm thinking about all examples in documentation. How we should do that? Use always
http-middlewareinterfaces (what version?) or aliases fromwebimpress/http-middleware-compatibility? IMHO, final library users should use http-middleware interfaces directly.