This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow full, unfettered usage across all PHPUnit versions #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing #40 after-the-fact, I found a number of issues:
class_alias
to each test case in the test suite is problematic. These should be accomplished via an autoloader file.Zend\Test
namespace were using class names that were pre-6.0 versions of PHPUnit, which meant they still could not be used under that version.setExpectedException()
method, which was deprecated in the PHPUnit 5.7 series and removed in PHPUnit 6.This patch does the following to fix these issues:
class_alias
directives to a new file,autoload/phpunit-class-aliases.php
, which aliases the non-namespaced versions of bothTestCase
andExpectationFailedException
to the namespaced variants, allowing usage of the namespaced variants throughout all source code and tests.assertApplicationException()
to detect if pre-6.0 versions of PHPUnit are in use, and, if so, usessetExpectedException()
; if not, usesexpectException()
, and optionallyexpectExceptionMessage()
.ZendTest\Test\ExpectedExceptionTrait
, with the methodexpectedException()
. It uses thesetExpectedException()
signature, and then, based on the version of PHPUnit detected, proxies either tosetExpectedException()
orexpectException()
+ optionallyexpectExceptionMessage()
.TODO