#6760 #6787 - simplified test logic (skip test early if it has to be …

…skipped)
zendframework · Dec 31, 2014 · 01bc2bf · 01bc2bf
1 parent d4e9c1c
commit 01bc2bf
Showing 1 changed file with 22 additions and 22 deletions.
diff --git a/tests/ZendTest/Db/Adapter/Driver/Pgsql/ConnectionTest.php b/tests/ZendTest/Db/Adapter/Driver/Pgsql/ConnectionTest.php
@@ -56,31 +56,31 @@ public function testResource()
      */
     public function testGetConnectionStringEncodeSpecialSymbol()
     {
-        if (extension_loaded('pgsql')) {
-            $connectionParameters = array(
-                'driver'    => 'pgsql',
-                'host' => 'localhost',
-                'post' => '5432',
-                'dbname' => 'test',
-                'username'  => 'test',
-                'password'  => 'test123!',
-            );
+        if (! extension_loaded('pgsql')) {
+            $this->markTestSkipped('pgsql extension not loaded');
+        }
 
-            $this->connection->setConnectionParameters($connectionParameters);
+        $connectionParameters = array(
+            'driver'    => 'pgsql',
+            'host' => 'localhost',
+            'post' => '5432',
+            'dbname' => 'test',
+            'username'  => 'test',
+            'password'  => 'test123!',
+        );
 
-            $getConnectionString = new ReflectionMethod(
-                'Zend\Db\Adapter\Driver\Pgsql\Connection',
-                'getConnectionString'
-            );
+        $this->connection->setConnectionParameters($connectionParameters);
 
-            $getConnectionString->setAccessible(true);
+        $getConnectionString = new ReflectionMethod(
+            'Zend\Db\Adapter\Driver\Pgsql\Connection',
+            'getConnectionString'
+        );
 
-            $this->assertEquals(
-                'host=localhost user=test password=test123! dbname=test',
-                $getConnectionString->invoke($this->connection)
-            );
-        } else {
-            $this->markTestSkipped('pgsql extension not loaded');
-        }
+        $getConnectionString->setAccessible(true);
+
+        $this->assertEquals(
+            'host=localhost user=test password=test123! dbname=test',
+            $getConnectionString->invoke($this->connection)
+        );
     }
 }