Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fixes #6760 : decode http_build_query on connection string at Pgsql Connection #6787

Closed
wants to merge 1 commit into from
Closed

Fixes #6760 : decode http_build_query on connection string at Pgsql Connection #6787

wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Contributor

Fixes #6760

@samsonasik samsonasik mentioned this pull request Oct 20, 2014
Closed
@samsonasik samsonasik changed the title Fixes #6760 : encode http_build_query on connection string at Pgsql Connection Fixes #6760 : decode http_build_query on connection string at Pgsql Connection Oct 20, 2014
@samsonasik
Copy link
Contributor Author

@Ocramius is it merge-able ?

@Ocramius Ocramius added this to the 2.3.4 milestone Dec 19, 2014
@Ocramius Ocramius self-assigned this Dec 19, 2014
@Ocramius
Copy link
Member

@samsonasik I think so: I'll pull it locally and merge tomorrow.

@samsonasik
Copy link
Contributor Author

ping @Ocramius ready to merge ?

@Ocramius
Copy link
Member

@samsonasik it's already in my queue for the next round of merges

@samsonasik
Copy link
Contributor Author

@Ocramius thank you ;)

@Ocramius
Copy link
Member

I will remove the new public method on merge.

Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - making getConnectionString private
314db7f
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - simplified getConnectionString logic (direct return v…
0a60dfd 
…alue)
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - simplified connection parameters selection logic
9c4ea9b
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - getConnectionString is private and cannot be access…
e35ae82 
…ed directly in the test case
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - removing useless try-catch
d4e9c1c
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - simplified test logic (skip test early if it has to be …
01bc2bf 
…skipped)
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - adding @group annotation for newly introduced tests
2d72800
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - test doesn't need to be skipped when the pgsql extens…
dd749c6 
…ion isn't loaded
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - refactoring test logic (early return)
60f8469
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
#6760 #6787 - removing unused property
bb2f8c2
@Ocramius Ocramius closed this in e5cc91c Dec 31, 2014
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
Merge branch 'hotfix/#6787-connection-string-parameters-to-be-decoded…
7ad2c0f 
…' into develop

Close #6787
Close #6760
Forward port #6787
Forward port #6760
@Ocramius
Copy link
Member

Fixed some minor issues and made the getConnectionString method private.

Merged, thanks @samsonasik!

master: e5cc91c
develop: 7ad2c0f

@samsonasik samsonasik deleted the hotfix/encode-httpbuildquery branch December 31, 2014 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
bug Db
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

pg_connect params encodings
3 participants
@samsonasik @Ocramius @jeremyquinton