[#4380] CS fixes

- s/Extensions/Extension/g
- Added explanatory comments
- Alias both exception types in DateTime validator

library/Zend/Form/View/Helper/FormDateTimeSelect.php

@@ -26,12 +26,13 @@ class FormDateTimeSelect extends FormDateSelectHelper
     protected $timeType;
 
     /**
-     * @throws Exception\ExtensionsNotLoadedException if ext/intl is not present
+     * @throws Exception\ExtensionNotLoadedException if ext/intl is not present
      */
     public function __construct()
     {
         parent::__construct();
 
+        // Delaying initialization until we know ext/intl is available
         $this->timeType = IntlDateFormatter::LONG;
     }
 

library/Zend/Form/View/Helper/FormMonthSelect.php

@@ -47,7 +47,7 @@ class FormMonthSelect extends AbstractHelper
     protected $locale;
 
     /**
-     * @throws Exception\ExtensionsNotLoadedException if ext/intl is not present
+     * @throws Exception\ExtensionNotLoadedException if ext/intl is not present
      */
     public function __construct()
     {
@@ -58,6 +58,7 @@ public function __construct()
             ));
         }
 
+        // Delaying initialization until we know ext/intl is available
         $this->dateType = IntlDateFormatter::LONG;
     }
 

library/Zend/I18n/Validator/DateTime.php

@@ -14,7 +14,7 @@
 use Traversable;
 use Zend\I18n\Exception as I18nException;
 use Zend\Validator\AbstractValidator;
-use Zend\Validator\Exception;
+use Zend\Validator\Exception as ValidatorException;
 
 class DateTime extends AbstractValidator
 {
@@ -81,7 +81,7 @@ class DateTime extends AbstractValidator
      * Constructor for the Date validator
      *
      * @param array|Traversable $options
-     * @throws Exception\ExtensionNotLoadedException if ext/intl is not present
+     * @throws I18nException\ExtensionNotLoadedException if ext/intl is not present
      */
     public function __construct($options = array())
     {
@@ -92,6 +92,7 @@ public function __construct($options = array())
             ));
         }
 
+        // Delaying initialization until we know ext/intl is available
         $this->dateType = IntlDateFormatter::NONE;
         $this->timeType = IntlDateFormatter::NONE;
         $this->calendar = IntlDateFormatter::GREGORIAN;
@@ -252,7 +253,7 @@ public function getLocale()
      *
      * @param  string                             $value
      * @return bool
-     * @throws Exception\InvalidArgumentException
+     * @throws ValidatorException\InvalidArgumentException
      */
     public function isValid($value)
     {
@@ -267,7 +268,7 @@ public function isValid($value)
         $formatter = $this->getIntlDateFormatter();
 
         if (intl_is_failure($formatter->getErrorCode())) {
-            throw new Exception\InvalidArgumentException("Invalid locale string given");
+            throw new ValidatorException\InvalidArgumentException("Invalid locale string given");
         }
 
         $position   = 0;