This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Form Elements refactor: move "options" out of attributes (Select, Radio, etc.) #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $this; | ||
| } | ||
| return parent::setAttribute($key, $value); | ||
| } |
There was a problem hiding this comment.
With this here, it won't break those setting the options in the attributes. Deprecate it in the future?
There was a problem hiding this comment.
Yes -- but for now, keep it to keep BC.
weierophinney
added a commit
that referenced
this pull request
Aug 28, 2012
- Detailed change to elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to clean up the Element attributes, and move out value options into it's own property.
Affects Select, Radio, and MultiCheckbox elements and view helpers.