Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix #3161 by checking if the server port already exists in the host #3167

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion library/Zend/View/Helper/ServerUrl.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function setHost($host)
if (($scheme == 'http' && (null === $port || $port == 80))
|| ($scheme == 'https' && (null === $port || $port == 443))
) {
$this->host = $host;;
$this->host = $host;
return $this;
}

Expand Down Expand Up @@ -180,6 +180,15 @@ protected function detectHost()
}

if (isset($_SERVER['HTTP_HOST']) && !empty($_SERVER['HTTP_HOST'])) {
// Detect if the port is set in SERVER_PORT and included in HTTP_HOST
if (isset($_SERVER['SERVER_PORT'])) {
$portStr = ':' . $_SERVER['SERVER_PORT'];
if (substr($_SERVER['HTTP_HOST'], 0-strlen($portStr), strlen($portStr)) == $portStr) {
$this->setHost(substr($_SERVER['HTTP_HOST'], 0, 0-strlen($portStr)));
return;
}
}

$this->setHost($_SERVER['HTTP_HOST']);
return;
}
Expand Down
9 changes: 9 additions & 0 deletions tests/ZendTest/View/Helper/ServerUrlTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,15 @@ public function testConstructorWithHostIncludingPortAndHttpsTrue()
$this->assertEquals('https://example.com:8181', $url->__invoke());
}

public function testConstructorWithHttpHostIncludingPortAndPortSet()
{
$_SERVER['HTTP_HOST'] = 'example.com:8181';
$_SERVER['SERVER_PORT'] = 8181;

$url = new Helper\ServerUrl();
$this->assertEquals('http://example.com:8181', $url->__invoke());
}

public function testConstructorWithHttpHostAndServerNameAndPortSet()
{
$_SERVER['HTTP_HOST'] = 'example.com';
Expand Down