Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

remove surplus call deep namespace #3473

Closed
wants to merge 2 commits into from
Closed

remove surplus call deep namespace #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b20094
remove surplus namespace
samsonasik Jan 17, 2013
61452b2
remove deep namespace docblock
samsonasik Jan 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/Zend/Mvc/Router/Console/Catchall.php
View file
Open in desktop
Expand Up @@ -72,12 +72,12 @@ class Catchall implements RouteInterface
protected $assembledParams = array();

/**
* @var \Zend\Validator\ValidatorChain
* @var ValidatorChain
*/
protected $validators;

/**
* @var \Zend\Filter\FilterChain
* @var FilterChain
*/
protected $filters;

Expand Down
2 changes: 1 addition & 1 deletion library/Zend/Mvc/Service/ControllerLoaderFactory.php
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ class ControllerLoaderFactory implements FactoryInterface
/**
* Create the controller loader service
*
* Creates and returns an instance of Controller\ControllerManager. The
* Creates and returns an instance of ControllerManager. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have the entire name to avoid conflicts between two namespaces with the same class name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maks3w : should I change to \Zend\Mvc\Controller\ControllerManager ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maks3w : in use statement, it already defined as 'use Zend\Mvc\Controller\ControllerManager', cmiiw.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct in here as-is, as the ControllerManager class is imported into the current file.

* only controllers this manager will allow are those defined in the
* application configuration's "controllers" array. If a controller is
* matched, the scoped manager will attempt to load the controller.
Expand Down