Fix radio & multicheckbox disable #4160
Conversation
|
This wasn't the way I told you to fix it tho. I don't know in which case $optionSpec['disabled'] is set, but the code is probably there for a reason. This PR makes that if-statement useless. |
| @@ -258,7 +258,6 @@ protected function renderOptions(MultiCheckboxElement $element, array $options, | |||
| $value = ''; | |||
| $label = ''; | |||
| $selected = false; | |||
| $disabled = false; | |||
There was a problem hiding this comment.
Add this back in, move it down to row 264 and change false to isset($inputAttributes['disabled']) ? true : false
There was a problem hiding this comment.
Only testing isset() is wrong, is the "disabled" option could be set to false and isset() would return true.
There was a problem hiding this comment.
I don't know when "Disabled" will come in $options array. Because "Disable" is actually Attribute of form element.
There was a problem hiding this comment.
Ah, yeah. That's true. Does anyone know when and how $optionSpec['disabled'] is used? Sounds like the idea is that you'll be able to disable just a single radio instead of all of them.
Please refer this issue.
#4136