Locale aware fix #5034

Merged
merged 2 commits into from Oct 21, 2013

Conversation

Projects
None yet
3 participants
@corentin-larose
Contributor

corentin-larose commented Aug 27, 2013

  • This patch makes PhoneNumber validator locale aware.
  • This installs a new dependency on INTL extension which was already there for a lot of filters/validators in Zend/I18n.
  • If agreed, I will add unit tests.
@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Aug 28, 2013

Member

@corentin-larose Go for it.

Member

weierophinney commented Aug 28, 2013

@corentin-larose Go for it.

@Maks3w

This comment has been minimized.

Show comment
Hide comment
@Maks3w

Maks3w Oct 21, 2013

Member

Closed due inactivity

Member

Maks3w commented Oct 21, 2013

Closed due inactivity

@Maks3w Maks3w closed this Oct 21, 2013

@corentin-larose

This comment has been minimized.

Show comment
Hide comment
@corentin-larose

corentin-larose Oct 21, 2013

Contributor

Sorry for inactivity, added U.T in #5312, I think this fix is very important !

Contributor

corentin-larose commented Oct 21, 2013

Sorry for inactivity, added U.T in #5312, I think this fix is very important !

@Maks3w Maks3w reopened this Oct 21, 2013

@ghost ghost assigned Maks3w Oct 21, 2013

Maks3w added a commit that referenced this pull request Oct 21, 2013

@Maks3w Maks3w merged commit 1dfd2e8 into zendframework:develop Oct 21, 2013

1 check failed

default The Travis CI build failed
Details

@corentin-larose corentin-larose deleted the qapa:Locale-aware-fix branch Mar 14, 2014

gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment