Content-Transfer-Encoding value not case sensitive

[denis-sokolov]

No description provided.

[denis-sokolov]

Travis found trailing spaces

Oh, so proposing pull requests from a Github web-editor is not such a great idea.
Will push a fix right away.

[denis-sokolov]

The latest test failure is unrelated to the pull request.

[samsonasik]

you should provide unit test

[denis-sokolov]

Unit test added.

[macnibblet]

According to your comment the RFC says it's not case sensitive.... That would mean your call to strtolower is pointless ?

[denis-sokolov]

According to RFC, anyone can call setTransferEncoding with quOtED-PrinTablE and that is the same as if when they call it with quoted-printable.
Pre-pr code throws an exception on the following line. Post-pr code handles it correctly.

Similarly, the output of getFieldValue can be quoted-printable or QUoTeD-PrintablE.
Current implementation always returns the lowercase variant,
but in my unit test, I do not want to rely on this implementation detail, that is why I call strtolower.

Does that sound a bit clearer, @macnibblet?

[Maks3w]

@denis-sokolov Could you apply the same fix to the equivalent HTTP Header?

[denis-sokolov]

@Maks3w, do you mean the Http\-namespaced class?
That one does not have the problem, because it did not even try to implement anything.
Quoting:

// @todo implementation details
$header->value = $value;

Why keep two similar classes, though?
If needed for semantic purposes, can't you make Http\ one use Mail\ one internally?
Or vice-versa. This way improvements to one would automatically work with the other.

[Maks3w]

Each header is proposed from a different organization and with different porpouse. So different implementations are expected.

[Maks3w]

Just normalize the value in the other class.

[denis-sokolov]

What do you want me to normalize?
Http\ class conforms to the spec already.

[denis-sokolov]

Besides, if the classes are meant to be so different, with different purposes and different implementations,
I suggest these placing these improvements to Http\ class in a different pull request by a different author. :)