This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Minor BC] Remove translation of validator keys #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the translation of validator message ***keys*** which is totally absurd in the first place. They are constants that should not be modified.
| @@ -96,7 +96,7 @@ public function testMaximumErrorMessageLength() | |||
|
|
|||
| $loader = new TestAsset\ArrayTranslator(); | |||
| $loader->translations = array( | |||
| Alpha::INVALID => 'This is the translated message for %value%', | |||
| 'Invalid type given. String expected' => 'This is the translated message for %value%', | |||
There was a problem hiding this comment.
Why this? If the constant does not aim to be readable then we can still relying in the value whatever it is.
There was a problem hiding this comment.
Because we are not translating the validator message _keys_ but the validator messages
There was a problem hiding this comment.
In theory it would be nice to do $validator->templateMessages[Alpha::INVALID] => '...' but templateMessages is protected so it's not possiblo
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2014
…age-key-translation [Minor BC] Remove translation of validator keys
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2014
- Like #5666, this is technically a BC break and needs a note in the changelog.
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2014
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…otfix/remove-validator-message-key-translation [Minor BC] Remove translation of validator keys
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the translation of validator message _keys_ which is totally
absurd in the first place. They are constants that should not be
modified.