patch #5860

[samsonasik]

patch #5860

[Maks3w]

When this return false?

[Maks3w]

@samsonasik May is better stop a moment and share what rules are you intended to apply.

[samsonasik]

@Maks3w based on #5860 , there are lot of suggested changes, but I just want to put that it appliable at zf2 and keep that it still support for consistencies, like @return self, @param bool instead of boolean like @weierophinney pointed at #3342 and #4436 (comment) . I have read the Coding Standard that pointed docblock too http://phpdoc.org and for @return type, it linked to http://phpdoc.org/docs/latest/references/phpdoc/types.html . if there is a rule that must be applied, please let me know. Thank you.

[Ocramius]

The bool or boolean problem is no big deal - alignment on docblocks is likely going to conflict with some PRs, but that's also no big deal - can probably be changed in scrutinizer itself.

@return self is actually correct and supported by phpdoc - is there any problem with that?

[samsonasik]

@Ocramius yes, but for consistency. btw, alignment fixed. should I continue ? /cc @Maks3w

[Ocramius]

Rebased and merged manually - work can go on from here IMO

[Maks3w]

@Ocramius I disagree with this. Fix may types but also remove other types allowed or expected to return.

[Ocramius]

@Maks3w I agree that there may be imperfections, but the code was (in general) improved and functionally kept intact/unchanged, so I went on and merged this. I'd rather see additional fixes or cleanups (even if they fix these changes) rather than trying to slow down nitpicking (causing slowdown) @samsonasik, who has already been doing a lot for #5860 :-)

[Maks3w]

We should to have a criteria and don't change something just because some tool throws a warning. Think if the warning is correct or a false positive before change any code.

[Ocramius]

@Maks3w I went through the diffs and I didn't (and still don't) see false positives tbh