This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Removed duplicate class declarations #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
added a commit
that referenced
this pull request
Feb 28, 2012
Removed duplicate class declarations
|
Thanks Pavel, really appreciate it. |
gianarb
pushed a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…ix-multiple-class-declarations Removed duplicate class declarations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to generate API for Zend Framework 2 with ApiGen (http://apigen.org) -- which is very strict and hates multiple class declaration), I've encountered a strange thing in zf2.
Root.php and Replace.php were both having the same class name in their namespace.
So I've renamed class Replace in Root.php to Root, according to PSR-0 standard.
EDIT: Found all bad declarations and fixed them according to PSR-0 or common sense.
I've tried to run tests with "phpunit Zend/Markup/Renderer" and it went "OK (6 tests, 13 assertions)", so I guess this isn't BC break. :)