Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Add coveralls support and fix a few testing bugs related to coverage #4397

Closed
wants to merge 3 commits into from
Closed

Add coveralls support and fix a few testing bugs related to coverage #4397

wants to merge 3 commits into from

Conversation

DASPRiD
Copy link
Member

@DASPRiD DASPRiD commented May 3, 2013

This PR adds coveralls support (https://coveralls.io/) to ZF2. This tool integrates nicely with both GitHub and Travis, and allows us to keep track of our code coverage.

In the same run I fixed a few broken @covers annotations and a bug which prevented complete testing on Ubuntu 12.04 (see comments in the diff).

Coveralls status can be found at https://coveralls.io/r/zendframework/zf2

@DASPRiD
Copy link
Member Author

DASPRiD commented May 3, 2013

Mhh, something's still wrong with composer it seems.

@satooshi
Copy link

satooshi commented May 4, 2013

Please try to set src_dir: library in .coveralls.yml.

@DASPRiD
Copy link
Member Author

DASPRiD commented May 4, 2013

Oh indeed, I totally forgot that we have "library" as source folder, thanks.

@DASPRiD
Copy link
Member Author

DASPRiD commented May 4, 2013

Oh, just saw that you are the developer of php-coveralls, nice work on that!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 43e9a61 on DASPRiD:feature/coveralls-support into * on zendframework:master*.

@@ -8,6 +8,27 @@
],
"homepage": "http://framework.zend.com/",
"license": "BSD-3-Clause",
"repositories": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcov comes without composer support. perhabs someone can make a PR there first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure a requirement before this goes in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least we are already on a stable tag here ;)

@DASPRiD
Copy link
Member Author

DASPRiD commented May 7, 2013

Related issue, should be fixed soon (as in, today or tomorrow):
lemurheavy/coveralls-public#51

weierophinney added a commit that referenced this pull request Jun 28, 2013
Add coveralls support and fix a few testing bugs related to coverage
weierophinney added a commit that referenced this pull request Jun 28, 2013
- EOF ending
- trailing whitespace
weierophinney added a commit that referenced this pull request Jun 28, 2013
@ghost ghost assigned weierophinney Jun 28, 2013
@weierophinney
Copy link
Member

Merged to develop for 2.3.0 release.

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage
weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
- EOF ending
- trailing whitespace
weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants