Fix test suite when ext/intl isn't available

[dshafik]

• This will hopefully enable the testsuite to run in HHVM (see: this
  blog post)
• There were a bunch of errors caused by Zend\I18n\Validator\Int,
  switching some tests to use Zend\Validation\Digits might be a good
  idea

[Ocramius]

did you look into #5110 first? :)

[dshafik]

@Ocramius of... course not. BLAH!

I'll work with @TheFrozenFire to see which works better :)

[samsonasik]

remove @category @Package and @subpackage

[dshafik]

I'm not sure why you are wanting to do this? I followed the convention in the other tests.

[dshafik]

#3508 only applies to library and explicitly says not to apply to tests.

[samsonasik]

please take a look #3508 , it's old issue that we agree to remove all @category @Package and @subpackage. I only comment to remove new created one/all of them.

[dshafik]

This latest change takes sebastianbergmann/phpunit#997 into account — it's conditional on PHPUnit 3.8 (unreleased) and works with < PHPUnit 3.8 as well for now. Don't let it stop this going in. If @sebastianbergmann rejects the PR I'll patch these tests to remove it.

[Maks3w]

Following framework practice please split this test file and add a new one for each helper

[Maks3w]

@dshafik ZF2 has a minimum requirement on PHPUnit 3.7 so why not use @requires annotation?

http://phpunit.de/manual/3.7/en/incomplete-and-skipped-tests.html#incomplete-and-skipped-tests.requires.tables.api

[dshafik]

@Maks3w I believe it's because the data provider is still called. I don't remember why they didn't work, but I did try this and other options first.

[Maks3w]

@dshafik You'll get a better success in your PHPUnit PR if you prevent trigger @dataProvider when @requires is false

[dshafik]

@Maks3w then it would still run in older versions and fatal error. This has to be something that is possible to work in current and newer versions of PHPUnit. Fixing the @dataProvider/@requires thing for > 3.7 doesn't help, this code would STILL need to be in the dataProvider (at least the intl check and return empty data set).

[Maks3w]

@weierophinney The referenced PHPUnit versions DON'T EXISTS! The patch proposed is not merged.

[weierophinney]

@Maks3w If Sebastian chooses not to merge it, @dshafik has indicated he'll issue a revert. Indications at this point are that it will be merged, however.