This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix for issue #5395 #5396
Merged
Fix for issue #5395 #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CS and testing issues introduced by security fix for zendframework#5374
Fixes CS issues
| * @param bool $checkAbstractFactories | ||
| * @param bool $usePeeringServiceManagers | ||
| * @return bool | ||
| */ | ||
| public function has($name, $checkAbstractFactories = true, $usePeeringServiceManagers = true) | ||
| { | ||
| if ($this->canCreate($name, $checkAbstractFactories)) { | ||
| if (is_string($name)) { |
There was a problem hiding this comment.
move the is_string check first since most usage of this function are string based
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2013
- Move opening conditional statement to same line as condition - s/name/rName/ in string check for canonical name - Trigger E_USER_DEPRECATED error from canCreate()
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2013
ghost
assigned
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…/develop Fix for issue zendframework/zendframework#5395
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
- Move opening conditional statement to same line as condition - s/name/rName/ in string check for canonical name - Trigger E_USER_DEPRECATED error from canCreate()
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ocramius has noted the method is going to be depracte but i thought id try to do a quick patch