Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child key derivation - unnecessary code duplication. #6

Open
tzachvk opened this issue Oct 10, 2018 · 2 comments
Open

child key derivation - unnecessary code duplication. #6

tzachvk opened this issue Oct 10, 2018 · 2 comments

Comments

@tzachvk
Copy link

tzachvk commented Oct 10, 2018

When deriving child keys from master key 1 and master key 2,
the same code path should be used.
@omershlo
Copy link
Contributor

solved in #9 . @tzachvk please review

@omershlo
Copy link
Contributor

update: for 2p-Schnorr MasterKey1 and MasterKey2 are the same, therefore please use a unified MasterKey struct. For 2p-ECDSA there is a difference between the master keys in the private keys . @tzachvk any suggestions on how to share code in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omershlo @tzachvk