generalize asset id in standard amm #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Allows the consumer to use any
AssetId
when instantiating the "standard" AMM. In my case I would like to directly use theCurrencyId
instead of converting to and fromzenlink_protocol::AssetId
since we anyway will have XCM disabled (see this comment). The important thing to note is that this PR does not introduce any functional changes since the consumer may still use the concreteAssetId
type andPairLpGenerate
.