Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #2675

Merged
merged 7 commits into from
May 8, 2024
Merged

Updated Readme #2675

merged 7 commits into from
May 8, 2024

Conversation

AlexejPenner
Copy link
Contributor

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Copy link
Contributor

coderabbitai bot commented May 6, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels May 6, 2024
@strickvl strickvl added documentation Improvements or additions to documentation and removed enhancement New feature or request labels May 6, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Few quick things

  • let’s add a run on Google collab button at the top when we talk about zenml go given the interview we just had
  • there should be a GIF instead of ‘GIF of running a pipeline and running on k8s (potentially showing other DAG renders as well?)’
  • On the phone the GIFs appear a bit small … can we make it slightly bigger? To make it easier to see

@AlexejPenner
Copy link
Contributor Author

AlexejPenner commented May 8, 2024

Nice!! Few quick things

  • let’s add a run on Google collab button at the top when we talk about zenml go given the interview we just had

Will add the colab button now.

  • there should be a GIF instead of ‘GIF of running a pipeline and running on k8s (potentially showing other DAG renders as well?)’

I will delete the line about the gif, I couldn't come up with anything meaningful for that gif in the given time frame. Separate PR will bring that in.

  • On the phone the GIFs appear a bit small … can we make it slightly bigger? To make it easier to see

Regarding gifs appearing small, this would require a change in the aspect ratio which means re-recording

@AlexejPenner AlexejPenner requested a review from htahir1 May 8, 2024 12:15
@AlexejPenner AlexejPenner merged commit 5a4c59c into develop May 8, 2024
7 checks passed
@AlexejPenner AlexejPenner deleted the feature/GRO-1088-README branch May 8, 2024 12:55
strickvl pushed a commit that referenced this pull request May 8, 2024
* Initial draft

* First two gifs

* Added fourth gif

* Slowed down gifs, resized headers, reduced top block

* Moved Header

* Applied suggestions

* Added Colab badge

(cherry picked from commit 5a4c59c)
strickvl added a commit that referenced this pull request May 8, 2024
* Add reranking section to LLMOps guide (#2679)

* add docs on rerankers

* update toc

* add try it out and code example links

* Optimised images with calibre/image-actions

* add placeholders for new diagrams

* 1ps becomes 1pp

* add images

* add missing image

* Optimised images with calibre/image-actions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 81cc853)

* Updated Readme (#2675)

* Initial draft

* First two gifs

* Added fourth gif

* Slowed down gifs, resized headers, reduced top block

* Moved Header

* Applied suggestions

* Added Colab badge

(cherry picked from commit 5a4c59c)

---------

Co-authored-by: Alexej Penner <thealexejpenner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants