deposits-ui: disable publish button on files #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
approved these changes
Jan 31, 2019
| angular.module('invenioRecords') | ||
| .filter('fieldtitle', fieldtitle) | ||
| .filter('notIn', notIn) | ||
| .filter('formatGrant', formatGrant) | ||
| .filter('limitToEllipsis', limitToEllipsis) | ||
| .filter('striptags', striptags) | ||
| .filter('stable', stable); | ||
| .filter('stable', stable) | ||
| .filter('check_all_files_uploaded',check_all_files_uploaded); |
There was a problem hiding this comment.
Suggested change
| .filter('check_all_files_uploaded',check_all_files_uploaded); | |
| .filter('checkAllFilesUploaded', check_all_files_uploaded); |
| <li> | ||
| <button | ||
| class="btn btn-primary" | ||
| data-toggle="modal" | ||
| data-target="#warningModal" | ||
| ng-hide="recordsVM.invenioRecordsArgs.templateParams.is_published" | ||
| ng-disabled="depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading" | ||
| ng-attr-title="{{(depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading) && 'You need to save your deposit first' || 'Publish the record'}}"> | ||
| ng-disabled="depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading || (filesVM.files | check_all_files_uploaded) || filesVM.files.length == 0" |
There was a problem hiding this comment.
Suggested change
| ng-disabled="depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading || (filesVM.files | check_all_files_uploaded) || filesVM.files.length == 0" | |
| ng-disabled="depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading || (filesVM.files | checkAllFilesUploaded) || filesVM.files.length == 0" |
| ng-attr-title="{{(depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading) && 'You need to save your deposit first' || 'Publish the record'}}"> | ||
| ng-disabled="depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading || (filesVM.files | check_all_files_uploaded) || filesVM.files.length == 0" | ||
| ng-attr-title="{{(depositionForm.$invalid || depositionForm.$dirty || recordsVM.invenioRecordsLoading) && 'You need to save your deposit first' | ||
| || (filesVM.files | check_all_files_uploaded) && 'There are pending files to be uploaded' |
There was a problem hiding this comment.
Suggested change
| || (filesVM.files | check_all_files_uploaded) && 'There are pending files to be uploaded' | |
| || (filesVM.files | checkAllFilesUploaded) && 'There are pending files to be uploaded' |
* Disable the publish button and display appropriate message in the case of selected but not uploaded files or if no selected files are present. (closes zenodo#1412)
Glignos
force-pushed
the
disable_publish_button_on_files
branch
from
ad54373
to
5b6bb45
Compare
ChiaraBi
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message in the case of selected but not uploaded files
or if no selected files are present. (closes deposit-ui: more intutitve file upload indicators #1412)