Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test with system php-fpm #93

Merged
merged 2 commits into from
Oct 21, 2015
Merged

fix test with system php-fpm #93

merged 2 commits into from
Oct 21, 2015

Conversation

remicollet
Copy link
Contributor

When using system php-fpm, test can fails, this should fix this:

  • -n option to not use system php.ini (which can include additional extensions)
  • don't change extension_dir (is enough, previous not really required with this change)
  • don't log notice, only warning (additional one break expected output, such as "NOTICE: systemd monitor interval set to 10000ms")

@zenovich
Copy link
Owner

I think the logs should remain in output. What's the reason for removing them?

@remicollet
Copy link
Contributor Author

Because of additional notices in some build (systemd), and the test is about runkit, not about fpm ;)

$ cat tests/runkit_fpm_internal_function_restore.diff
021+ [19-Oct-2015 09:50:22] NOTICE: systemd monitor interval set to 10000ms

@zenovich
Copy link
Owner

This doesn't work on my computer, and without logs I can't find out why.

  1
  2 ---- EXPECTED OUTPUT
  3 Test Start
  4 A B
  5 C D
  6 Test End
  7 
  8 Request ok
  9 Test Start
 10 A B
 11 C D
 12 Test End
 13 
 14 Request ok
 15 Test Start
 16 A B
 17 C D
 18 Test End
 19 
 20 Request ok
 21 Done
 22 ---- ACTUAL OUTPUT
 23 Warning: fsockopen(): unable to connect to 127.0.0.1:9004 (Connection refused) in /home/dzenovich/runkit-my/tests/_fcgi.inc on line 226
 24 Request error
 25 
 26 Warning: fsockopen(): unable to connect to 127.0.0.1:9004 (Connection refused) in /home/dzenovich/runkit-my/tests/_fcgi.inc on line 226
 27 Request error
 28 
 29 Warning: fsockopen(): unable to connect to 127.0.0.1:9004 (Connection refused) in /home/dzenovich/runkit-my/tests/_fcgi.inc on line 226
 30 Request error
 31 Done
 32 ---- FAILED

@remicollet
Copy link
Contributor Author

Sorry... I think this is related to missing space in fopen command.

I also revert log_level, but only check for the "ready to handle connections" and ignore remaining output.

I can squash the commits if you prefer a single clean one.

zenovich added a commit that referenced this pull request Oct 21, 2015
fix test with system php-fpm
@zenovich zenovich merged commit d9be90a into zenovich:master Oct 21, 2015
@remicollet
Copy link
Contributor Author

Tahnks

@remicollet remicollet deleted the issue-fpm branch October 21, 2015 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants