Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM deployment in Travis #100

Merged
merged 3 commits into from Jul 31, 2018
Merged

NPM deployment in Travis #100

merged 3 commits into from Jul 31, 2018

Conversation

Cremba
Copy link
Collaborator

@Cremba Cremba commented Jul 29, 2018

Improved travis.yml to deploy directly to npm

Improved travis.yml to deploy directly to npm
.travis.yml Outdated
- echo "@zen:registry=https://www.myget.org/F/zenprotocol/npm/" > .npmrc
- echo "//www.myget.org/F/zenprotocol/npm/:_authToken=$MYGET_TOKEN" >> .npmrc
install:
- npm i -g npm@latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this? isn't npm installed by default on travis?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I wanted to be sure that it install the latest version from npm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it fail without it? Ideally we want to make the builds pass as fast as possible, because when we're dev'ing, we don't want to wait long for PRs checks.

i would try without explicitly installing npm latest, and if it fails, try some solutions like in this issue

- npm run release
- npm run build
- npm run release
after_success: if [ $TRAVIS_OS_NAME = linux ] && [ ! -z "$TRAVIS_TAG" ]; then npm publish; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need npm pack before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm pack is to create a local package, npm publish will do the packaging and publish it to npm registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh right, npm build generates the build folder, my bad :)

Removed install section
@Cremba Cremba merged commit 8e02f1a into zenprotocol:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants