New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM deployment in Travis #100
Conversation
Improved travis.yml to deploy directly to npm
Edits to improve the deployments
.travis.yml
Outdated
- echo "@zen:registry=https://www.myget.org/F/zenprotocol/npm/" > .npmrc | ||
- echo "//www.myget.org/F/zenprotocol/npm/:_authToken=$MYGET_TOKEN" >> .npmrc | ||
install: | ||
- npm i -g npm@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this? isn't npm installed by default on travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I wanted to be sure that it install the latest version from npm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it fail without it? Ideally we want to make the builds pass as fast as possible, because when we're dev'ing, we don't want to wait long for PRs checks.
i would try without explicitly installing npm latest, and if it fails, try some solutions like in this issue
- npm run release | ||
- npm run build | ||
- npm run release | ||
after_success: if [ $TRAVIS_OS_NAME = linux ] && [ ! -z "$TRAVIS_TAG" ]; then npm publish; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need npm pack
before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm pack is to create a local package, npm publish will do the packaging and publish it to npm registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh right, npm build generates the build folder, my bad :)
Removed install section
Improved travis.yml to deploy directly to npm