Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM deployment in Travis #100

Merged
merged 3 commits into from
Jul 31, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
67 changes: 23 additions & 44 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,57 +1,36 @@
sudo: true

sudo: required
language: node_js

os:
- osx
- linux

sudo: required
- osx
- linux
dist: trusty

osx_image: xcode9.0

node_js:
- 8

branches:
only:
- master
- /^v\d+\.\d+(\.\d+)?(-\S*)?$/

- 8
cache:
yarn: true
directories:
- node_modules
- app/node_modules

- node_modules
- app/node_modules
addons:
apt:
sources:
- ubuntu-toolchain-r-test
- ubuntu-toolchain-r-test
packages:
- g++-4.8
- icnsutils
- graphicsmagick
- xz-utils
- xorriso

#install:
# - export CXX="g++-4.8"
# - yarn
# - cd app && yarn && cd ..
# - "/sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1280x1024x16"

#before_script:
# - export DISPLAY=:99.0
# - sh -e /etc/init.d/xvfb start &
# - sleep 3

- g++-4.8
- icnsutils
- graphicsmagick
- xz-utils
- xorriso
before_install:
- echo "@zen:registry=https://www.myget.org/F/zenprotocol/npm/" > .npmrc
- echo "//www.myget.org/F/zenprotocol/npm/:_authToken=$MYGET_TOKEN" >> .npmrc
install:
- npm i -g npm@latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this? isn't npm installed by default on travis?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I wanted to be sure that it install the latest version from npm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it fail without it? Ideally we want to make the builds pass as fast as possible, because when we're dev'ing, we don't want to wait long for PRs checks.

i would try without explicitly installing npm latest, and if it fails, try some solutions like in this issue

- npm i -g concurrently
- npm i -g cross-env
- npm i babel-register --save-dev
script:
# - node --version
# - yarn lint
# - yarn package
# - yarn test
# - yarn test-e2e
- npm run build
- npm run release
- npm run build
- npm run release
after_success: if [ $TRAVIS_OS_NAME = linux ] && [ ! -z "$TRAVIS_TAG" ]; then npm publish; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need npm pack before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm pack is to create a local package, npm publish will do the packaging and publish it to npm registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh right, npm build generates the build folder, my bad :)

3 changes: 1 addition & 2 deletions internals/auto-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ jq '.version = $val' --arg val "$1" package.json > "$tmp" && mv "$tmp" package.j
jq '.version = $val' --arg val "$1" app/package.json > "$tmp" && mv "$tmp" app/package.json
npm install
git commit -am "update npm dependencies for v$1"
npm run build && npm pack
npm publish

git tag v$1
git push origin v$1
git push
Expand Down