-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unexpected autoloads #71
Conversation
To quote the Emacs Lisp manual: > Simply loading a package should not change Emacs's editing > behavior. Include a command or commands to enable and disable the > feature, or to invoke it. > This convention is mandatory for any file that includes custom > definitions. If fixing such a file to follow this convention requires > an incompatible change, go ahead and make the incompatible change; > don't postpone it.
I've stumbled over this because |
If you can consistently repro that error, I'd like a repro and/or a fix for it first. |
I cannot reproduce the error I've mentioned (I did a Ruby upgrade from 2.1 to 2.2 and that's pretty much everything that might have caused it, it sounds like #69 since it later went away without any clear reason) and worse, cannot debug the ruby portions involved as long as The only way I can stop this from happening is putting something in my Emacs configuration which undoes this autoloaded change (which shouldn't have happened in the first place) or removing the package alltogether. Both are subpar, I'd rather keep the package and toggle whether I want to use it or not by having a line in my configuration automatically using it for a filetype which I can comment out for debugging purposes. |
I've tried downgrading my Ruby installation to 2.1 and that magically solved all errors I've had, so perhaps something got deprecated in 2.1 and removed in 2.2. |
Further discussion on |
Well, now that the source of the error is fixed, what about this pull request itself? |
Hrm... I just merged this, but I'm starting to disagree with it. Adding entries to Other progmodes that add to auto-mode-alist: bat-mode, cc-mode, python-mode, ruby-mode, vera-mode, vhdl-mode. I'm sure there is more because my regexp was quiet naive. |
All of these are built-in. I guess what I'm concerned about is that this changes an already existing association and that's what's making it unexpected. A similiar situation happened with js2-mode. Its author is aware that Emacs is already using |
To quote the Emacs Lisp manual: