Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] ArraySubsetAssertion now handles arrays-list #18

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[feat] ArraySubsetAssertion now handles arrays-list #18

merged 1 commit into from
Jul 12, 2022

Conversation

nikophil
Copy link
Member

No description provided.

@nikophil nikophil marked this pull request as draft July 11, 2022 16:11
@nikophil nikophil force-pushed the assert-array-lists-subset branch 6 times, most recently from c76c607 to 15b9d4b Compare July 11, 2022 17:01
@nikophil nikophil marked this pull request as ready for review July 11, 2022 17:03
nikophil
nikophil commented Jul 11, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
kbond
kbond reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small comment on the docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nikophil nikophil requested a review from kbond July 12, 2022 07:09
kbond
kbond approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikophil, this is excellent!

@kbond kbond merged commit a1c6501 into zenstruck:1.x Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikophil @kbond