Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "bundleless" usage #319

Closed
3 of 4 tasks
nikophil opened this issue Nov 2, 2022 · 1 comment · Fixed by #323
Closed
3 of 4 tasks

Remove "bundleless" usage #319

nikophil opened this issue Nov 2, 2022 · 1 comment · Fixed by #323
Labels
enhancement New feature or request

Comments

@nikophil
Copy link
Member

nikophil commented Nov 2, 2022

Based on #110 and #311 (comment) we would like to remove "bundleless" usage.

Here are some thoughts:

@nikophil nikophil added the enhancement New feature or request label Nov 2, 2022
@nikophil nikophil mentioned this issue Nov 2, 2022
13 tasks
@kbond
Copy link
Member

kbond commented Nov 3, 2022

we need to keep the ability to add global state in

We do but I wonder if this could be configured?

zenstruck_foundry:
    global_state:
        - invokable.service # just a service with ::invoke()
        - App\Stories\StoryThatIsAService
        - App\Stories\GlobalStory # if not a service, just run GlobalStory::load()
        - ...

Then global state could be used in your dev environment when loading fixtures. Stories as services could now be used as global state too.

If this can be done, maybe we can deprecate TestState::addGlobalState() too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants