New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] [remove bundleless usge] use config instead of environment variables #320
Conversation
67ff68e
to
355460e
Compare
355460e
to
e3ba666
Compare
38a94a6
to
29b6934
Compare
05b8a3a
to
b377fb3
Compare
b377fb3
to
25f208e
Compare
664cd05
to
e0af06e
Compare
about the test stuf, maybe a quick win would be to name our connections / managers with another name than "default" use this name in the config |
If not explicitly setting the connections/managers, does it use |
we're using default names: |
Ah, ok, hah - if we add a non-default connection/manager to the config for the tests, we lose the test for choosing the defaults... Let's leave untested for now - I don't want yet another test permutation. Of course, if there's a reported issue, we can re-evaluate. |
ok, hopefully we'll remove 5 or more test permutation after |
e0af06e
to
3dd8aa4
Compare
42e13ea
to
683eebe
Compare
683eebe
to
154edea
Compare
fixes #311
also related to #319
I don't really know if/how we should test this:
DatabaseResetter
(and ODM/ORM schema resetters) would be mocking hellEven testing the configuration would be tricky. I usually use a
KernelBuilder
for this.WDYT?