Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Allow to use foundry without Doctrine #323

Merged
merged 1 commit into from
Nov 10, 2022
Merged

[feat] Allow to use foundry without Doctrine #323

merged 1 commit into from
Nov 10, 2022

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Nov 9, 2022 •
edited

fixes #319

@nikophil nikophil force-pushed the feat/unit-test-bundleless branch 9 times, most recently from 1333083 to a10e3de Compare November 10, 2022 07:53
@nikophil nikophil requested a review from kbond November 10, 2022 08:15
@nikophil nikophil marked this pull request as ready for review November 10, 2022 08:15
kbond
kbond requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, we'll need some doc changes though.

What about:

  1. removing all reference to bundle-less usage.
  2. add a unit testing section to document/explain TestState::configure()

@nikophil nikophil force-pushed the feat/unit-test-bundleless branch 2 times, most recently from 045e14f to d86c553 Compare November 10, 2022 16:29
@nikophil nikophil requested a review from kbond November 10, 2022 16:45
@kbond kbond merged commit 3588274 into zenstruck:1.x Nov 10, 2022
@nikophil nikophil deleted the feat/unit-test-bundleless branch November 17, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "bundleless" usage
2 participants
@nikophil @kbond