Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with uncommon Santa target IDs #961

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix issues with uncommon Santa target IDs #961

merged 1 commit into from
Apr 24, 2024

Conversation

np5
Copy link
Member

@np5 np5 commented Apr 24, 2024

  • Relax Signing ID verification
  • Fix Signing ID search
  • Fix Team ID search
  • Fix rule creation form

@np5
Fix issues with uncommon Santa target IDs
e7a9f88 
 - Relax Signing ID verification
 - Fix Signing ID search
 - Fix Team ID search
 - Fix rule creation form
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8814803155

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 78.521%
Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/contrib/santa/forms.py 6 7 85.71%
Totals Coverage Status
Change from base Build 8719897290: 0.03%
Covered Lines: 35617
Relevant Lines: 45360
💛 - Coveralls

@np5 np5 merged commit e7a9f88 into main Apr 24, 2024
8 checks passed
@np5 np5 deleted the 20240423_santa_fixes branch April 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@np5 @coveralls