Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR] Generate dynamic ARG_INFO depending on PHP version #2341

Closed
Jeckerson opened this issue Jan 15, 2022 · 0 comments · Fixed by #2343
Closed

[NFR] Generate dynamic ARG_INFO depending on PHP version #2341

Jeckerson opened this issue Jan 15, 2022 · 0 comments · Fixed by #2343
Assignees
@Jeckerson
Labels
enhancement nfr New Feature Request

Comments

@Jeckerson
Copy link
Member

Currently it is only possible to dynamically inject specific code inside .c files via custom optimizers or via CBLOCK, but it is not possible to generate custom ARG_INFO for specific versions of PHP.

Example: Generate specific ARG_INFO for PHP7.4 and for >= PHP8.0
image
@Jeckerson Jeckerson added enhancement nfr New Feature Request labels Jan 15, 2022
@Jeckerson Jeckerson self-assigned this Jan 15, 2022
This was referenced Jan 15, 2022
Closed
Closed
Jeckerson added a commit that referenced this issue Jan 22, 2022
@Jeckerson
#2341 - Implement custom list of arg info defenition
177b6e5
@Jeckerson Jeckerson linked a pull request Jan 22, 2022 that will close this issue
#2341 - Implement custom list of arg info definition #2343
Merged
3 tasks
Jeckerson added a commit that referenced this issue Jan 22, 2022
@Jeckerson
#2341 - Fix CS
0555963
Jeckerson added a commit that referenced this issue Jan 22, 2022
@Jeckerson
#2341 - Add required methods __serialize() and __unserialize() fo…
8304a74 
…r PHP8.1
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Rename headers file
eba028e
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Rename headers file
6bc75b2
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Fix CS
86911a7
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Correct null check
7ba67e1
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Change to full class with namespace
dfae418
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Refactor renderPhalconCompatible() method
17d7722
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Update list in phalcon-compatibility-headers.php
b080d75
Jeckerson added a commit that referenced this issue Jan 23, 2022
@Jeckerson
#2341 - Refactor renderPhalconCompatible() method
d514b08
Jeckerson added a commit that referenced this issue Jan 24, 2022
@Jeckerson
#2341 - Update SessionHandlerInterface:gc() arg_info for PHP8.1
2382562
Jeckerson added a commit that referenced this issue Jan 24, 2022
@Jeckerson
#2341 - Fix number of args in `ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_T…
1c62f6c 
…YPE_MASK_EX`
Jeckerson added a commit that referenced this issue Feb 6, 2022
@Jeckerson
#2341 - Update CHANGELOG.md
30dd75c
Jeckerson added a commit that referenced this issue Feb 6, 2022
@Jeckerson
#2341 - Remove isGeneratedConstructor property
1528f43
AlexNDRmac added a commit that referenced this issue Feb 6, 2022
@AlexNDRmac
Merge pull request #2343 from zephir-lang/#2341-dynamic-arg-info
94972d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
enhancement nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2341 - Implement custom list of arg info definition zephir-lang/zephir
1 participant
@Jeckerson