Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2280 - Add string support in php.ini #2303

Merged
merged 6 commits into from
Oct 5, 2021
Merged

#2280 - Add string support in php.ini #2303

merged 6 commits into from
Oct 5, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Oct 5, 2021 •
edited
Loading

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson added nfr New Feature Request Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #2303 (3dbf5b1) into development (2ba1348) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             development   #2303   +/-   ##
=============================================
  Coverage           8.15%   8.15%           
- Complexity          8590    8592    +2     
=============================================
  Files                357     357           
  Lines              22216   22216           
=============================================
  Hits                1811    1811           
  Misses             20405   20405

@Jeckerson Jeckerson marked this pull request as ready for review October 5, 2021 13:24
@Jeckerson Jeckerson linked an issue Oct 5, 2021 that may be closed by this pull request
[NFR]: Support for string in php.ini settings #2280
Closed
@AlexNDRmac AlexNDRmac merged commit 4ef01e4 into development Oct 5, 2021
@AlexNDRmac AlexNDRmac deleted the #2280-php.ini-string-support branch October 5, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@AlexNDRmac AlexNDRmac AlexNDRmac approved these changes

Assignees
No one assigned
Labels
Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details hacktoberfest-accepted nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Support for string in php.ini settings
3 participants
@Jeckerson @niden @AlexNDRmac