Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context at the right time, fix errors missing stack traces #4

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

zephraph
Copy link
Owner

@zephraph zephraph commented Jun 2, 2021

Two things here:

  1. attaching the context directly to an operation caused some scoping/timing access problems. Instead of that the context is passed directly down to the executors.
  2. some error messages were missing stack traces. If there's no extra details on an error message (meaning it wasn't custom) then I'm just including the original stack trace.

@zephraph zephraph added the minor label Jun 2, 2021
@zephraph zephraph merged commit 5dff57e into master Jun 2, 2021
@zephraph zephraph deleted the better-context-and-fix-errors branch June 2, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant