Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write PID file after forking and before exiting. #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Write PID file after forking and before exiting. #137

wants to merge 1 commit into from

Conversation

quentinmit
Copy link
Contributor

No description provided.

achernya
achernya requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@achernya achernya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the commit description with why you're doing this? I assume this is for systemd compatibility / to make the PID file actually reflect the PID of the running process.

zhm/zhm.c
@@ -414,12 +414,13 @@ init_hm(void)
#ifndef DEBUG
if (!inetd && !nofork)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add { } to this statement? I don't like unblanaced if-else clauses where one has it and the other does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achernya achernya achernya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quentinmit @achernya