-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: script to auto-upload your test results #68
ci: script to auto-upload your test results #68
Conversation
163be34
to
17c24e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some basic cleanup before a more thorough review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
69cb411
to
72be075
Compare
@xuhao8210 I'm making changes of the upstream script, please review it too and my resolved conversations. Seems that we should use default sanitycheck names like reel_board.xml and etc. |
a895b61
to
7dcb2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clarifications on REAME file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maksimmasalski One last comment, (to comply with good practices on zephyr main repo) please squash your commits before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't you using create_pr() from the github module? this works just fine, I just tested again and it works as expected, basically push branch to your fork and submit the PR from there, so there is no additional manual steps.
7dcb2d1
to
c7205b9
Compare
c7205b9
to
60012a0
Compare
60012a0
to
0b41af9
Compare
Python script to automatically upload your HW Daily Test Results to the Github test_results repo Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>
0b41af9
to
6ac711a
Compare
logging.info('Source directory file path %s', source_file_path) | ||
git_file_path = os.path.join(git_dir_path, file_name) | ||
logging.info('Destination path to file to commit %s', git_file_path) | ||
shutil.copy(source_file_path, git_file_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error will be raised here while the file already exists. For example, we both run sanitycheck with iotdk
, so you may have already uploaded iotdk.xml
when I try to upload it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangnuannuan Yes, it will. I can add exception, but that question we can raise during TG Meeting today. Because, we except each company will upload results of their boards, and nobody can duplicate its test results. For example, your company is responsible for iotdk, and your must check results and provide only results for iotdk. No any other developer or company can upload iotdk results and duplicate them. Please, don't forget to raise that question during TW Meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nashif Do you have any input about that? Each company uploads separate boards, right?
@nashif Do we plan to merge it? |
Already made changes
logging.info('Push new repo updates to the origin ...') | ||
origin.git.push(origin_name, 'master') | ||
else: | ||
logging.info("Repository already created, let's update master...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the given directory is not a git repo? Maybe an error telling this? I think it is better to change the workflow, that first it checks if the directory exists (if not create dir), then if it is git repo and if not, initialize?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can add it, or add note in a Readme file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for changing the decision after such long time. I wanted to use the script and realize it is not working. Will continue debugging it and letting you know what might be wrong
According to out Testing WG discussion we will use manual uploading once per week. That will make our results more stable and without any additional garbage that can appear, if results will be uploaded automatically. |
Disentangle origin from upstream repos and update repo calls. Use pull --rebase for updating (regular pull does merge which can cause history conflicts) Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested Maciej's commit a051681, and it works well.
Python script to automatically upload your HW Daily Test Results
to the Github test_results repo
Signed-off-by: Maksim Masalski maksim.masalski@intel.com