-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace whitelist/blacklist with allowlist/blocklist #440
Merged
mbolivar-nordic
merged 1 commit into
zephyrproject-rtos:master
from
coderbyheart:remove-whitelist-blacklist
Sep 29, 2020
Merged
replace whitelist/blacklist with allowlist/blocklist #440
mbolivar-nordic
merged 1 commit into
zephyrproject-rtos:master
from
coderbyheart:remove-whitelist-blacklist
Sep 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2c9a48
to
f81236a
Compare
@mbolivar-nordic @tejlmand ready for review, all checks pass. |
mbolivar-nordic
suggested changes
Sep 23, 2020
tejlmand
requested changes
Sep 24, 2020
c3bd3ad
to
47f1d0d
Compare
@tejlmand all tests pass. Are the changes ok for you, now? |
mbolivar-nordic
suggested changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the update. I have these blocking requests:
- remove extra fields from
_import_map
type - settle on consistent naming with other projects doing this same change
- minor comment update
With those, I'm +1. Thanks again.
47f1d0d
to
3c5b5bb
Compare
This provides alternatives to the racially laden terms `whitelist`, used for a list of imports which are included, and `blacklist`, used for a list of imports which are excluded with `allowlist` and respectively `blocklist`. Signed-off-by: Markus Tacker <Markus.Tacker@NordicSemi.no>
3c5b5bb
to
1c89048
Compare
tejlmand
approved these changes
Sep 29, 2020
mbolivar-nordic
approved these changes
Sep 29, 2020
Thanks @coderbyheart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides alternatives to the racially laden terms
whitelist
,used for a list of imports which are included, and
blacklist
, usedfor a list of imports which are excluded with
includelist
andrespectively
excludelist
.