Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace whitelist/blacklist with allowlist/blocklist #440

Merged
merged 1 commit into from
Sep 29, 2020
Merged

replace whitelist/blacklist with allowlist/blocklist #440

merged 1 commit into from
Sep 29, 2020

Conversation

coderbyheart
Copy link
Contributor

@coderbyheart coderbyheart commented Sep 18, 2020 •
edited

This provides alternatives to the racially laden terms whitelist,
used for a list of imports which are included, and blacklist, used
for a list of imports which are excluded with includelist and
respectively excludelist.

@coderbyheart
Copy link
Contributor Author

@mbolivar-nordic @tejlmand ready for review, all checks pass.

mbolivar-nordic
mbolivar-nordic suggested changes Sep 23, 2020
View reviewed changes
src/west/manifest.py Outdated Show resolved Hide resolved
@coderbyheart coderbyheart marked this pull request as draft September 23, 2020 22:48
tejlmand
tejlmand requested changes Sep 24, 2020
View reviewed changes
src/west/manifest.py Outdated Show resolved Hide resolved
@coderbyheart coderbyheart force-pushed the remove-whitelist-blacklist branch 3 times, most recently from c3bd3ad to 47f1d0d Compare September 24, 2020 14:57
@coderbyheart coderbyheart changed the title replace whitelist/blacklist with allowlist/denylist replace whitelist/blacklist with includelist/excludelist Sep 24, 2020
@coderbyheart coderbyheart marked this pull request as ready for review September 24, 2020 15:51
@coderbyheart
Copy link
Contributor Author

@tejlmand all tests pass. Are the changes ok for you, now?

mbolivar-nordic
mbolivar-nordic suggested changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the update. I have these blocking requests:

  • remove extra fields from _import_map type
  • settle on consistent naming with other projects doing this same change
  • minor comment update

With those, I'm +1. Thanks again.

src/west/manifest.py Outdated Show resolved Hide resolved
tests/test_manifest.py Outdated Show resolved Hide resolved
@coderbyheart
replace whitelist/blacklist with allowlist/denylist
1c89048 
This provides alternatives to the racially laden terms `whitelist`,
used for a list of imports which are included, and `blacklist`, used
for a list of imports which are excluded with `allowlist` and
respectively `blocklist`.

Signed-off-by: Markus Tacker <Markus.Tacker@NordicSemi.no>
@mbolivar-nordic mbolivar-nordic merged commit 11c2cb2 into zephyrproject-rtos:master Sep 29, 2020
@mbolivar-nordic
Copy link
Contributor

Thanks @coderbyheart

@coderbyheart coderbyheart deleted the remove-whitelist-blacklist branch September 29, 2020 22:04
@mbolivar-nordic mbolivar-nordic changed the title replace whitelist/blacklist with includelist/excludelist replace whitelist/blacklist with allowlist/blocklist Oct 8, 2020
@rexut rexut mentioned this pull request Jul 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejlmand tejlmand tejlmand approved these changes

@mbolivar-nordic mbolivar-nordic mbolivar-nordic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coderbyheart @mbolivar-nordic @tejlmand