-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
drivers: adxl362: don't disable callbacks
Enabling and disabling the GPIO callbacks is error prone and unnecessary since the trigger data is protected with a mutex, so it has been removed. This resolves the following issues: - The GPIO callbacks are not being re-enabled properly in the error path of the trigger setting function. - The device pointer used in the GPIO callback to retrieve the ADXL362 driver configuration data is the GPIO device not the ADXL362 device, so this cast is invalid and the int_gpio field is garbage. - There are potential timing issues between enabling interrupts and re-enabling the callbacks. Signed-off-by: Brett Witherspoon <spoonb@cdspooner.com>
- Loading branch information
1 parent
6746470
commit 0e92570
Showing
1 changed file
with
3 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters