Skip to content

Commit

Permalink
subsys: shell: Add missing dependency to SERIAL
Browse files Browse the repository at this point in the history
The shell subsystem, as it is today, depends on having a UART,
therefore let's add the dependency explicitly in its Kconfig

Fixes #10190

Signed-off-by: Alberto Escolar Piedras <alpi@oticon.com>
  • Loading branch information
aescolar authored and carlescufi committed Sep 27, 2018
1 parent c09b76a commit 3e41ac5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions samples/subsys/shell/shell_module/prj.conf
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
CONFIG_PRINTK=y
CONFIG_SHELL=y
CONFIG_SERIAL=y
CONFIG_LOG=y
CONFIG_LOG_BACKEND_UART=n
CONFIG_KERNEL_SHELL=y
Expand Down
1 change: 1 addition & 0 deletions samples/subsys/shell/shell_module/prj_minimal.conf
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
CONFIG_PRINTK=y
CONFIG_SHELL=y
CONFIG_SERIAL=y
CONFIG_LOG_BACKEND_UART=n
CONFIG_KERNEL_SHELL=n
CONFIG_OBJECT_TRACING=y
Expand Down
1 change: 1 addition & 0 deletions subsys/shell/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ menuconfig SHELL
bool "Enable shell"
select LOG_RUNTIME_FILTERING
select POLL
depends on SERIAL

if SHELL

Expand Down

0 comments on commit 3e41ac5

Please sign in to comment.