Skip to content

Commit

Permalink
drivers: ethernet: Kconfig: Remove redundant 'default n' properties
Browse files Browse the repository at this point in the history
Bool symbols implicitly default to 'n'.

A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you
want to override a 'default y' on the base definition of the symbol. It
isn't used like that on any of these symbols though, and is
inconsistent.

This will make the auto-generated Kconfig documentation have "No
defaults. Implicitly defaults to n." as well, which is clearer than
'default n if ...'

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
  • Loading branch information
ulfalizer authored and nashif committed Jul 3, 2018
1 parent 04cc6bf commit 86c4686
Show file tree
Hide file tree
Showing 29 changed files with 0 additions and 102 deletions.
3 changes: 0 additions & 3 deletions drivers/ethernet/Kconfig.dw
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,15 @@ menuconfig ETH_DW
bool
prompt "Synopsys DesignWare Ethernet driver"
depends on NET_L2_ETHERNET
default n
help
Enable Synopsys DesignWare Ethernet driver.

if ETH_DW
config ETH_DW_SHARED_IRQ
bool
default n

config ETH_DW_0
bool "Synopsys DesignWare Ethernet port 0"
default n
help
Include port 0 driver

Expand Down
4 changes: 0 additions & 4 deletions drivers/ethernet/Kconfig.enc28j60
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ menuconfig ETH_ENC28J60
bool "ENC28J60C Ethernet Controller"
depends on NET_L2_ETHERNET
depends on SPI
default n
help
ENC28J60C Stand-Alone Ethernet Controller
with SPI Interface
Expand Down Expand Up @@ -43,7 +42,6 @@ config ETH_EN28J60_TIMEOUT
config ETH_ENC28J60_0
bool "ENC28J60C Ethernet port 0"
depends on ETH_ENC28J60
default n
help
Include port 0 driver

Expand Down Expand Up @@ -85,14 +83,12 @@ config ETH_ENC28J60_0_SLAVE

config ETH_ENC28J60_0_GPIO_SPI_CS
bool "Manage SPI CS through a GPIO pin"
default n
help
This option is useful if one needs to manage SPI CS through a GPIO
pin to by-pass the SPI controller's CS logic.

config ETH_ENC28J60_0_SPI_CS_PORT_NAME
string "SPI cs port name"
default ""
depends on ETH_ENC28J60_0_GPIO_SPI_CS
help
Master SPI port name through which ENC28J60C chip is accessed.
Expand Down
4 changes: 0 additions & 4 deletions drivers/ethernet/Kconfig.mcux
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ menuconfig ETH_MCUX
bool
prompt "MCUX Ethernet driver"
depends on NET_L2_ETHERNET && HAS_MCUX
default n
help
Enable MCUX Ethernet driver. Note, this driver performs one shot PHY
setup. There is no support for PHY disconnect, reconnect or
Expand All @@ -17,7 +16,6 @@ menuconfig ETH_MCUX
if ETH_MCUX
config ETH_MCUX_PROMISCUOUS_MODE
bool "Enable promiscuous mode"
default n
help
Place the Ethernet receiver in promiscuous mode. This may be useful
for debugging and not needed for normal work.
Expand All @@ -31,7 +29,6 @@ config ETH_MCUX_PHY_TICK_MS

config ETH_MCUX_PHY_EXTRA_DEBUG
bool "Enable additional detailed PHY debug"
default n
help
Enable additional PHY related debug information related to
PHY status polling.
Expand All @@ -54,7 +51,6 @@ config ETH_MCUX_TX_BUFFERS

config ETH_MCUX_0
bool "MCUX Ethernet port 0"
default n
help
Include port 0 driver

Expand Down
1 change: 0 additions & 1 deletion drivers/ethernet/Kconfig.native_posix
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
menuconfig ETH_NATIVE_POSIX
bool "Native Posix Ethernet driver"
depends on ARCH_POSIX && NET_L2_ETHERNET
default n
help
Enable native posix ethernet driver. Note, this driver is run inside
a process in your host system.
Expand Down
1 change: 0 additions & 1 deletion drivers/ethernet/Kconfig.sam_gmac
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ menuconfig ETH_SAM_GMAC
bool
prompt "Atmel SAM Ethernet driver"
depends on SOC_FAMILY_SAM
default n
help
Enable Atmel SAM MCU Family Ethernet driver.

Expand Down
1 change: 0 additions & 1 deletion drivers/ethernet/Kconfig.stm32_hal
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ menuconfig ETH_STM32_HAL
bool
prompt "STM32 HAL Ethernet driver"
depends on NET_L2_ETHERNET
default n
select USE_STM32_HAL_ETH
help
Enable STM32 HAL based Ethernet driver.
Expand Down
6 changes: 0 additions & 6 deletions drivers/serial/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
menuconfig SERIAL
bool
prompt "Serial Drivers"
default n
help
Enable options for serial drivers.

Expand All @@ -19,31 +18,27 @@ comment "Capabilities"

config SERIAL_HAS_DRIVER
bool
default n
help
This is an option to be enabled by individual serial driver
to signal that there is a serial driver. This is being used
by other drivers which are dependent on serial.

config SERIAL_SUPPORT_INTERRUPT
bool
default n
help
This is an option to be enabled by individual serial driver
to signal that the driver and hardware supports interrupts.

config UART_INTERRUPT_DRIVEN
bool
prompt "Enable UART Interrupt support"
default n
depends on SERIAL_SUPPORT_INTERRUPT
help
This option enables interrupt support for UART allowing console
input and other UART based drivers.

config UART_LINE_CTRL
bool "Enable Serial Line Control API"
default n
help
This enables the API for apps to control the serial line,
such as baud rate, CTS and RTS.
Expand All @@ -54,7 +49,6 @@ config UART_LINE_CTRL

config UART_DRV_CMD
bool "Enable driver commands API"
default n
help
This enables the API to send extra commands to drivers.
This allows drivers to expose hardware specific functions.
Expand Down
1 change: 0 additions & 1 deletion drivers/serial/Kconfig.altera_jtag
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
menuconfig UART_ALTERA_JTAG
bool "Nios II JTAG UART driver"
default n
select SERIAL_HAS_DRIVER
help
Enable the Altera JTAG UART driver, built in to many Nios II CPU
Expand Down
1 change: 0 additions & 1 deletion drivers/serial/Kconfig.cc32xx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
menuconfig UART_CC32XX
depends on SOC_SERIES_CC32XX
bool "CC32XX UART driver"
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
depends on SOC_FAMILY_TISIMPLELINK
Expand Down
6 changes: 0 additions & 6 deletions drivers/serial/Kconfig.cmsdk_apb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

menuconfig UART_CMSDK_APB
bool "ARM CMSDK APB UART driver"
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
depends on SOC_FAMILY_ARM
Expand All @@ -21,39 +20,34 @@ if UART_CMSDK_APB

config UART_CMSDK_APB_PORT0
bool "Enable driver for UART 0"
default n
help
Build the driver to utilize UART controller Port 0.

# ---------- Port 1 ----------

config UART_CMSDK_APB_PORT1
bool "Enable driver for UART 1"
default n
help
Build the driver to utilize UART controller Port 1.

# ---------- Port 2 ----------

config UART_CMSDK_APB_PORT2
bool "Enable driver for UART 2"
default n
help
Build the driver to utilize UART controller Port 2.

# ---------- Port 3 ----------

config UART_CMSDK_APB_PORT3
bool "Enable driver for UART 3"
default n
help
Build the driver to utilize UART controller Port 3.

# ---------- Port 4 ----------

config UART_CMSDK_APB_PORT4
bool "Enable driver for UART 4"
default n
help
Build the driver to utilize UART controller Port 4.

Expand Down
1 change: 0 additions & 1 deletion drivers/serial/Kconfig.esp32
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
menuconfig UART_ESP32
bool "ESP32 UART driver"
default n
select SERIAL_HAS_DRIVER
depends on SOC_ESP32
help
Expand Down
3 changes: 0 additions & 3 deletions drivers/serial/Kconfig.fe310
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
menuconfig UART_FE310
bool "SiFive Freedom E310 serial driver"
depends on SOC_RISCV32_FE310
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
help
Expand All @@ -18,7 +17,6 @@ menuconfig UART_FE310

menuconfig UART_FE310_PORT_0
bool "Enable FE310 Port 0"
default n
depends on UART_FE310
help
This tells the driver to configure the UART port at boot, depending on
Expand Down Expand Up @@ -66,7 +64,6 @@ config UART_FE310_PORT_0_TXCNT_IRQ

menuconfig UART_FE310_PORT_1
bool "Enable FE310 Port 1"
default n
depends on UART_FE310
help
This tells the driver to configure the UART port at boot, depending on
Expand Down
3 changes: 0 additions & 3 deletions drivers/serial/Kconfig.gecko
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ menuconfig UART_GECKO
bool "Gecko uart driver"
depends on HAS_SILABS_GECKO
depends on GPIO_GECKO
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
help
Expand All @@ -19,7 +18,6 @@ if UART_GECKO

menuconfig UART_GECKO_0
bool "UART 0"
default n
help
Enable UART 0.

Expand All @@ -36,7 +34,6 @@ endif # UART_GECKO_0

menuconfig UART_GECKO_1
bool "UART 1"
default n
help
Enable UART 1.

Expand Down
8 changes: 0 additions & 8 deletions drivers/serial/Kconfig.imx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

menuconfig UART_IMX
bool "NXP i.MX7 family processor UART driver"
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
depends on HAS_IMX_HAL
Expand All @@ -18,55 +17,48 @@ menuconfig UART_IMX

config UART_IMX_UART_1
bool "Enable NXP i.MX7 UART1 Port"
default n
depends on UART_IMX
help
Enable support for UART1 port in the driver. Say y here
if you want to use UART1 device.

config UART_IMX_UART_2
bool "Enable NXP i.MX7 UART2 Port"
default n
depends on UART_IMX
help
Enable support for UART2 port in the driver. Say y here
if you want to use UART2 device.

config UART_IMX_UART_3
bool "Enable NXP i.MX7 UART3 Port"
default n
depends on UART_IMX
help
Enable support for UART3 port in the driver. Say y here
if you want to use UART3 device.

config UART_IMX_UART_4
bool "Enable NXP i.MX7 UART4 Port"
default n
depends on UART_IMX
help
Enable support for UART4 port in the driver. Say y here
if you want to use UART4 device.

config UART_IMX_UART_5
bool "Enable NXP i.MX7 UART5 Port"
default n
depends on UART_IMX
help
Enable support for UART5 port in the driver. Say y here
if you want to use UART5 device.

config UART_IMX_UART_6
bool "Enable NXP i.MX7 UART6 Port"
default n
depends on UART_IMX
help
Enable support for UART6 port in the driver. Say y here
if you want to use UART6 device.

config UART_IMX_UART_7
bool "Enable NXP i.MX7 UART7 Port"
default n
depends on UART_IMX
help
Enable support for UART7 port in the driver. Say y here
Expand Down
7 changes: 0 additions & 7 deletions drivers/serial/Kconfig.mcux
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
menuconfig UART_MCUX
bool "MCUX uart driver"
depends on HAS_MCUX && CLOCK_CONTROL
default n
select SERIAL_HAS_DRIVER
select SERIAL_SUPPORT_INTERRUPT
help
Expand All @@ -18,37 +17,31 @@ if UART_MCUX

menuconfig UART_MCUX_0
bool "UART 0"
default n
help
Enable UART 0.

menuconfig UART_MCUX_1
bool "UART 1"
default n
help
Enable UART 1.

menuconfig UART_MCUX_2
bool "UART 2"
default n
help
Enable UART 2.

menuconfig UART_MCUX_3
bool "UART 3"
default n
help
Enable UART 3.

menuconfig UART_MCUX_4
bool "UART 4"
default n
help
Enable UART 4.

menuconfig UART_MCUX_5
bool "UART 5"
default n
help
Enable UART 5.

Expand Down
2 changes: 0 additions & 2 deletions drivers/serial/Kconfig.mcux_lpc_usart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
menuconfig USART_MCUX_LPC
bool "MCUX USART driver"
depends on HAS_MCUX
default n
select SERIAL_HAS_DRIVER
help
Enable the MCUX USART driver.
Expand All @@ -16,7 +15,6 @@ if USART_MCUX_LPC

menuconfig USART_MCUX_LPC_0
bool "USART 0"
default n
help
Enable USART 0.

Expand Down
Loading

0 comments on commit 86c4686

Please sign in to comment.