Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :190995]Control flow issues in /subsys/net/ip/ipv6.c #13830

Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Closed

[Coverity CID :190995]Control flow issues in /subsys/net/ip/ipv6.c #13830

mandarcthorat1 opened this issue Feb 27, 2019 · 0 comments
Assignees
@jukkar
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /subsys/net/ip/ipv6.c
Category: Control flow issues
Function: net_ipv6_input
Component: Networking
CID: 190995
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added the priority: medium Medium impact/importance bug label Feb 27, 2019
jukkar added a commit to jukkar/zephyr that referenced this issue Feb 28, 2019
@jukkar
net: ipv6: Extension header length failure not properly checked
05ee45e 
The ipv6_handle_ext_hdr_options() can return negative value
but we stored it into unsigned variable and then checked < 0.

Coverity-CID: 190995
Fixes zephyrproject-rtos#13830

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@jukkar jukkar mentioned this issue Feb 28, 2019
Merged
galak pushed a commit that referenced this issue Feb 28, 2019
@jukkar @galak
net: ipv6: Extension header length failure not properly checked
8e066ab 
The ipv6_handle_ext_hdr_options() can return negative value
but we stored it into unsigned variable and then checked < 0.

Coverity-CID: 190995
Fixes #13830

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jukkar @galak @mandarcthorat1