Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hci_uart controller driver loses sync after host driver is reset #15333

Closed
lemrey opened this issue Apr 10, 2019 · 0 comments
Closed

hci_uart controller driver loses sync after host driver is reset #15333

lemrey opened this issue Apr 10, 2019 · 0 comments
Assignees
@carlescufi
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug

Comments

@lemrey
Copy link
Collaborator

lemrey commented Apr 10, 2019 •
edited
Loading

The hci_uart controller driver will lose synchronization with the host, if the host is reset while sending data. If the controller driver is reset, the host can wait for a NOP from the controller before continuing;
this can serve as a synchronization mechanism. However, the hci_uart sample does not emit a NOP command.

Solution:
Emit a NOP command from the hci_uart controller driver,
to signal to the host that the controller is ready.
@lemrey lemrey added the Enhancement Changes/Updates/Additions to existing features label Apr 10, 2019
@lemrey lemrey added bug The issue is a bug, or the PR is fixing a bug and removed Enhancement Changes/Updates/Additions to existing features labels Apr 10, 2019
@lemrey lemrey changed the title Let HCI controller driver emit a NOP when ready hci_uart controller driver loses sync after host driver is reset Apr 10, 2019
@carlescufi carlescufi added area: Bluetooth platform: nRF Nordic nRFx priority: medium Medium impact/importance bug labels Apr 10, 2019
@lemrey lemrey mentioned this issue Apr 10, 2019
Merged
carlescufi added a commit to carlescufi/zephyr that referenced this issue Apr 11, 2019
@carlescufi
samples: Bluetooth: hci_uart: Implement NOP Command Complete
63b3dbd 
Implement the Controller counterpart to CONFIG_BT_WAIT_NOP so that it
issues a NOP Command Complete event after booting up, to signal to the
Host that it is ready to receive HCI traffic.

Fixes zephyrproject-rtos#15333

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi added a commit that referenced this issue Apr 11, 2019
@carlescufi
samples: Bluetooth: hci_uart: Implement NOP Command Complete
bae9f19 
Implement the Controller counterpart to CONFIG_BT_WAIT_NOP so that it
issues a NOP Command Complete event after booting up, to signal to the
Host that it is ready to receive HCI traffic.

Fixes #15333

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlescufi carlescufi

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemrey @carlescufi