Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microchip XEC rtos timer should be using values coming from DTS #17775

Closed
tbursztyka opened this issue Jul 25, 2019 · 1 comment · Fixed by #23409
Closed

Microchip XEC rtos timer should be using values coming from DTS #17775

tbursztyka opened this issue Jul 25, 2019 · 1 comment · Fixed by #23409
Assignees
@scottwcpg
Labels
area: Devicetree area: Drivers area: Timer Timer bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@tbursztyka
Copy link
Collaborator

Though dts/arm/microchip/mec1501hsz.dtsi provide the right values (base address, irq...), code source found in drivers/timer/mchp_xec_rtos_timer.c use none of these.

Using HAL is nice in case of a lot of code being already written and drivers can then make a good use of it, but things like macros for base address, IRQ ... not really
@tbursztyka tbursztyka added bug The issue is a bug, or the PR is fixing a bug area: Drivers area: Timer Timer labels Jul 25, 2019
@ioannisg ioannisg added the priority: low Low impact/importance bug label Jul 28, 2019
@rljordan-zz rljordan-zz modified the milestones: v2.0.0, v2.1.0 Aug 27, 2019
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Aug 27, 2019
drivers/timer: Use DTS interrupt info for XEC driver
5219ee1 
irq and irq priority must be taken from DTS generated configuration
macros.

Seems like driver requires the priority to be set to 1, thus setting it
to 1 in the relevant dtsi file.

Fixes zephyrproject-rtos#17775

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
@tbursztyka tbursztyka assigned scottwcpg and unassigned tbursztyka Dec 3, 2019
@dleach02 dleach02 modified the milestones: v2.1.0, v2.2.0 Dec 10, 2019
@jhedberg jhedberg modified the milestones: v2.2.0, v2.3.0 Mar 10, 2020
@nashif
Copy link
Member

nashif commented Mar 11, 2020

@albertofloyd @dcpleung @franciscomunoz can you please look it that? it seems part of it was already addressed?

@nashif nashif removed this from the v2.3.0 milestone Mar 11, 2020
dcpleung added a commit to dcpleung/zephyr that referenced this issue Mar 11, 2020
@dcpleung
timer: mchp_xec_rtos: convert to use DT_INST_ defines
b776630 
Use DT_INST_* instead of the hard-coded macro from the HAL,
as DT_INST_* are preferred.

Fixes zephyrproject-rtos#17775

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung dcpleung mentioned this issue Mar 11, 2020
Merged
nashif pushed a commit that referenced this issue Mar 12, 2020
@dcpleung @nashif
timer: mchp_xec_rtos: convert to use DT_INST_ defines
711f88a 
Use DT_INST_* instead of the hard-coded macro from the HAL,
as DT_INST_* are preferred.

Fixes #17775

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Mar 18, 2020
@dcpleung @hakehuang
timer: mchp_xec_rtos: convert to use DT_INST_ defines
53e77e8 
Use DT_INST_* instead of the hard-coded macro from the HAL,
as DT_INST_* are preferred.

Fixes zephyrproject-rtos#17775

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottwcpg scottwcpg

Labels
area: Devicetree area: Drivers area: Timer Timer bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

timer: mchp_xec_rtos: convert to use DT_INST_ defines dcpleung/zephyr
8 participants
@nashif @jhedberg @tbursztyka @ioannisg @rljordan-zz @galak @dleach02 @scottwcpg