Bluetooth ：Mesh：Provison init should after proxy

[LingaoM]

zephyr/subsys/bluetooth/mesh/main.c

Lines 292 to 328 in bce3354

	int bt_mesh_init(const struct bt_mesh_prov *prov,
	const struct bt_mesh_comp *comp)
	{
	int err;
	err = bt_mesh_test();
	if (err) {
	return err;
	}
	err = bt_mesh_comp_register(comp);
	if (err) {
	return err;
	}
	if (IS_ENABLED(CONFIG_BT_MESH_PROV)) {
	err = bt_mesh_prov_init(prov);
	if (err) {
	return err;
	}
	}
	bt_mesh_net_init();
	bt_mesh_trans_init();
	bt_mesh_beacon_init();
	bt_mesh_adv_init();
	if (IS_ENABLED(CONFIG_BT_MESH_PROXY)) {
	bt_mesh_proxy_init();
	}
	if (IS_ENABLED(CONFIG_BT_SETTINGS)) {
	bt_mesh_settings_init();
	}
	return 0;
	}

Provision use pb-gatt use buffer from proxy client, however proxy client init after prov init. Prov init call reset_state to allocate buf from proxy client, get-proxy-buf call net_buf_simple_reset to init buf->data = buf->__buf, but at this time buf->__buf currently not initiating.

[jhedberg]

You're right, this looks like a real bug - I'm surprised no one has noticed since it results in the provisioning buffer having buf->data pointing to NULL. The fix should be as simple as reordering the calls in bt_mesh_init() i.e. so that bt_mesh_proxy_init() gets called before bt_mesh_prov_init().

[jhedberg]

@moringe can you confirm that the following would solve the issue:

--- a/subsys/bluetooth/mesh/main.c
+++ b/subsys/bluetooth/mesh/main.c
@@ -304,6 +304,10 @@ int bt_mesh_init(const struct bt_mesh_prov *prov,
                return err;
        }
 
+       if (IS_ENABLED(CONFIG_BT_MESH_PROXY)) {
+               bt_mesh_proxy_init();
+       }
+
        if (IS_ENABLED(CONFIG_BT_MESH_PROV)) {
                err = bt_mesh_prov_init(prov);
                if (err) {
@@ -316,10 +320,6 @@ int bt_mesh_init(const struct bt_mesh_prov *prov,
        bt_mesh_beacon_init();
        bt_mesh_adv_init();
 
-       if (IS_ENABLED(CONFIG_BT_MESH_PROXY)) {
-               bt_mesh_proxy_init();
-       }
-
        if (IS_ENABLED(CONFIG_BT_SETTINGS)) {
                bt_mesh_settings_init();
        }