Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gPTP should allow user setting of priority1 and priority2 fields used in BMCA #28151

Closed
jukkar opened this issue Sep 8, 2020 · 0 comments · Fixed by #28158
Closed

gPTP should allow user setting of priority1 and priority2 fields used in BMCA #28151

jukkar opened this issue Sep 8, 2020 · 0 comments · Fixed by #28158
Assignees
@jukkar
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@jukkar
Copy link
Member

jukkar commented Sep 8, 2020 •
edited
Loading

Describe the bug
The BMCA (Best Master Clock selection Algorithm) uses priority1 and priority2 parameters. Currently the value of these is hardcoded and cannot be changed by the user. It should be possible to user to tweak them as needed. One way to allow tweaking is to provide the values as Kconfig options.
@jukkar jukkar added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Networking labels Sep 8, 2020
@jukkar jukkar self-assigned this Sep 8, 2020
@jukkar jukkar mentioned this issue Sep 8, 2020
Merged
jukkar added a commit to jukkar/zephyr that referenced this issue Sep 8, 2020
@jukkar
net: gptp: Allow user to tweak priority1 and priority2 values
079d80a 
Instead of hardcoding the priority1 and priority2 values used
in BMCA, let the user tweak the values via Kconfig.

Fixes zephyrproject-rtos#28151

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@jukkar jukkar mentioned this issue Sep 8, 2020
Merged
jukkar added a commit to jukkar/zephyr that referenced this issue Sep 8, 2020
@jukkar
net: gptp: Allow user to tweak priority1 and priority2 values
1e2cbdd 
Instead of hardcoding the priority1 and priority2 values used
in BMCA, let the user tweak the values via Kconfig.

Fixes zephyrproject-rtos#28151

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
MaureenHelm pushed a commit that referenced this issue Sep 22, 2020
@jukkar @MaureenHelm
net: gptp: Allow user to tweak priority1 and priority2 values
e3fd170 
Instead of hardcoding the priority1 and priority2 values used
in BMCA, let the user tweak the values via Kconfig.

Fixes #28151

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
nashif pushed a commit that referenced this issue Sep 23, 2020
@jukkar @nashif
net: gptp: Allow user to tweak priority1 and priority2 values
744fadc 
Instead of hardcoding the priority1 and priority2 values used
in BMCA, let the user tweak the values via Kconfig.

Fixes #28151

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow user to modify gPTP BMCA priority1 and priority2 variables jukkar/zephyr
1 participant
@jukkar